Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resourcemanager: do not check existence when add resource group (#6717) #6739

Merged
merged 7 commits into from
Oct 12, 2023
Merged

resourcemanager: do not check existence when add resource group (#6717) #6739

merged 7 commits into from
Oct 12, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #6717

What problem does this PR solve?

Issue Number: ref #5851, ref pingcap/tidb#45050

What is changed and how does it work?

Do not check the existence of target resource group to make create resource group idempotent.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

glorv added 6 commits July 3, 2023 06:53
@glorv @ti-chi-bot
do not check existance when add resource group
b3586cb 
Signed-off-by: glorv <glorvs@163.com>
@glorv @ti-chi-bot
fix test
5210e2a 
Signed-off-by: glorv <glorvs@163.com>
@glorv @ti-chi-bot
fix test
9fe1128 
Signed-off-by: glorv <glorvs@163.com>
@glorv @ti-chi-bot
change name
31c8b3a 
Signed-off-by: glorv <glorvs@163.com>
@glorv @ti-chi-bot
remove useless error code
324fcce 
Signed-off-by: glorv <glorvs@163.com>
@glorv @ti-chi-bot
fix typo
109a03d 
Signed-off-by: glorv <glorvs@163.com>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 3, 2023
Merged
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 3, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • HuSharp

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Jul 3, 2023
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Jul 3, 2023
@ti-chi-bot ti-chi-bot bot requested review from JmPotato and rleungx July 3, 2023 06:53
@HuSharp HuSharp requested review from CabinfeverB and HuSharp and removed request for JmPotato and rleungx July 3, 2023 06:54
@codecov
Copy link

codecov bot commented Jul 3, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
pkg/mcs/resource_manager/server/manager.go 82.02% <ø> (+1.58%) ⬆️

... and 72 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 3, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 3, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 5, 2023
@HuSharp
Copy link
Member

HuSharp commented Jul 10, 2023 •
edited
Loading

@CabinfeverB Can you leave a merge label? thx!

@CabinfeverB
Copy link
Member

#6717 may introduce consistency problem when creating resource group in TiDB

@CabinfeverB
Copy link
Member

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 10, 2023
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Jul 13, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 27, 2023
@CabinfeverB
Copy link
Member

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 11, 2023

@CabinfeverB: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 11, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 109a03d

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 11, 2023
@CabinfeverB
Copy link
Member

/hold cancel

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 11, 2023

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit b0477c9 into tikv:release-7.1 Oct 12, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HuSharp HuSharp HuSharp approved these changes

@CabinfeverB CabinfeverB CabinfeverB approved these changes

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @HuSharp @CabinfeverB @glorv